Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrBLUP is actually still using R #2

Open
oddoking opened this issue Feb 22, 2024 · 2 comments
Open

rrBLUP is actually still using R #2

oddoking opened this issue Feb 22, 2024 · 2 comments

Comments

@oddoking
Copy link

Hi,
I want to speak about my understanding. This code rrBUP.py is a wrapper to get data ready and call R functions to get the answer. So in essence, it is still R?

@zhejiangzhuque
Copy link
Owner

Thanks for your comment. You are right, this code is just a R function calling wrapper temporarily, to ensure the consistency.

As you can see, for instance, in line 413 to 416 within the code with a comment format, we originally had used scipy.optimize.fminbound function in Python to replace optimize function in R, but found a different result.

We will find a solution of this issue in the future.

@oddoking
Copy link
Author

oddoking commented Feb 27, 2024

@zhejiangzhuque

I created a pull request in an effort to use pure python code. The key change is sort eigen values/vestors before optimsing lambda.. See if my change is useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants