Derive Default and Eq where possible
#1565
Closed
+13
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use Rust's default deriving mechanism, until rust-lang/rust#26925 and rust-lang/rust#7671 are fixed. But fortunately, there's a crate for that.
matthiasgoergens
requested review from
muursh,
wborgeaud and
Nashtare
as code owners
|
Nashtare
reviewed
Apr 5, 2024
There was a problem hiding this comment.
I am not really in favor of these changes. I don't see the problem of having a few custom implementations of Default or Eq, especially if it prevents including an additional dependency that hasn't been maintained for the past 3 years.
Is the current implementation problematic in any way for your usecase?
|
You are right that the crate hasn't been updated in a while. Well, I hope the Rust compiler gets fixed at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use Rust's default deriving mechanism, until rust-lang/rust#26925 and rust-lang/rust#7671 are fixed.
But fortunately, there's a crate for that.