-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-forking state refactor #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [skip ci] - because #353 not yet merged
10 tasks
FabijanC
commented
Mar 6, 2024
FabijanC
commented
Mar 6, 2024
marioiordanov
approved these changes
Mar 6, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Temporarily disable--state-archive-capacity full
(shall be restored by Old state support #353)Development related changes
StarknetState
CachedState
commitment diffCommittedClassStorage
(property ofStarknetState
)DictState
DictStateReader
testing utility with addedState
(writing) functionalityCachedState
always takesDictState
as its underlying state, but in a future PR this will be made generic to support aForkedState
that will be the same asDictState
, but will also an originStateChanger
: where applicable, replaced withblockifier::State
StateExtractor
: where applicable, replaced withblockifier::StateReader
CustomState
andCustomStateReader
impl CustomStateReader
, the methods of these traits could be implemented directly underStarknetState
&mut state
state.read()
tostate.write()
accordinglyDeployed
toPredeployed
and its methods accordingly (predeploy, predeclare)StateDiff
:ThinStateDiff
Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
cargo test