Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed partially custom BlockId implementation #344

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Feb 12, 2024

Usage related changes

Development related changes

Implemented as_ref method for wrapper BlockId(starknet-rs::BlockId) to return reference to its inner type.
Removed usage if any of our custom BlockId implementation and left only its custom deserialisation.
Refactored methods to receive &BlockId as an argument, instead of BlockId, to avoid copying of 32 bytes. Copying is done because starknet-rs BlockId implements the Copy trait.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@marioiordanov marioiordanov linked an issue Feb 12, 2024 that may be closed by this pull request
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I assume the remaining checkboxes could be checked. Also, even though the PR title contains the word "partially", we don't plan to make more changes related to this, right?

@marioiordanov
Copy link
Contributor Author

Looks good, I assume the remaining checkboxes could be checked. Also, even though the PR title contains the word "partially", we don't plan to make more changes related to this, right?

No, no more changes related to BlockId

@marioiordanov marioiordanov merged commit 6bb2fc1 into main Feb 13, 2024
1 check passed
@marioiordanov marioiordanov deleted the one_block_id branch February 13, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are there two BlockId implementations
2 participants