Removed partially custom BlockId implementation #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
Implemented as_ref method for wrapper
BlockId(starknet-rs::BlockId)
to return reference to its inner type.Removed usage if any of our custom BlockId implementation and left only its custom deserialisation.
Refactored methods to receive
&BlockId
as an argument, instead ofBlockId
, to avoid copying of 32 bytes. Copying is done because starknet-rs BlockId implements the Copy trait.Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
cargo test