Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty params deserialization #351

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Fix empty params deserialization #351

merged 3 commits into from
Feb 15, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Feb 15, 2024 •
edited
Loading

Usage related changes

Development related changes

  • None

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@FabijanC FabijanC marked this pull request as draft February 15, 2024 10:42
@FabijanC FabijanC changed the title Print chain ID on startup Fix empty params deserialization Feb 15, 2024
@FabijanC FabijanC marked this pull request as ready for review February 15, 2024 11:20
@FabijanC FabijanC merged commit 0f3c1ab into main Feb 15, 2024
@FabijanC FabijanC deleted the print-chain-id branch February 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FabijanC @marioiordanov