Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate pending block generation into new block generation #359

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Incorporate pending block generation into new block generation #359

merged 1 commit into from
Feb 22, 2024

Conversation

FabijanC
Copy link
Contributor

Usage related changes

  • None, hopefully

Development related changes

  • Reduces code complexity by making pending block generation the last step of new block generation.
  • Could also be useful for Old state support #353

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

marioiordanov
marioiordanov approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets goooo

@FabijanC FabijanC merged commit e3c6901 into main Feb 22, 2024
1 check passed
@FabijanC FabijanC deleted the incorporate-pending-generation branch February 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FabijanC @marioiordanov