Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set time generate_block option #362

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Add set time generate_block option #362

merged 16 commits into from
Feb 29, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Feb 27, 2024 •
edited
Loading

Usage related changes

  • Add generate_block option in set time API call

Development related changes

  • next_block_timestamp property in Starknet struct was added

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@mikiw
Copy link
Contributor Author

mikiw commented Feb 27, 2024

Dump functionality is still missing

@mikiw mikiw marked this pull request as draft February 27, 2024 13:30
@mikiw mikiw linked an issue Feb 28, 2024 that may be closed by this pull request
New optional parameter to set time #355
Closed
@mikiw
Copy link
Contributor Author

mikiw commented Feb 28, 2024 •
edited
Loading

I just need to add doc now...

@mikiw mikiw marked this pull request as ready for review February 28, 2024 09:38
FabijanC
FabijanC requested changes Feb 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/api/http/models.rs Show resolved Hide resolved
crates/starknet-devnet/tests/test_dump_and_load.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/api/http/endpoints/time.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_advancing_time.rs Outdated Show resolved Hide resolved
@mikiw mikiw merged commit 804b361 into main Feb 29, 2024
1 check passed
@mikiw mikiw deleted the set-time-generate-block branch February 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

@marioiordanov marioiordanov Awaiting requested review from marioiordanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New optional parameter to set time
2 participants
@mikiw @FabijanC