-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc 0.7.0 #364
Merged
Merged
rpc 0.7.0 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
FabijanC
requested changes
Feb 29, 2024
crates/starknet-devnet-core/src/starknet/add_deploy_account_transaction.rs
Show resolved
Hide resolved
crates/starknet-devnet-server/src/api/json_rpc/spec_reader/mod.rs
Outdated
Show resolved
Hide resolved
1 task
FabijanC
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
RPC 0.7.0
Starknet 0.13.1
Development related changes
CasmContractClass
is moved fromcairo_lang_starknet
tocairo_lang_starknet_classes
.gas_price
toNonZeroU128
fromu64
, so conversions can be avoided.estimate_transaction_fee
to use blockifier helper functionsMAX_BYTECODE_SIZE_LIMIT
constant which is needed for converting from Sierra to Cash (https://spaceshard.slack.com/archives/C05FAMWQ8JE/p1708269433783959)execution_resources
to tracesget_versioned_constants
method that replaces constants regarding VMResources, such as builtins and steps, using default blockifier values.get_transaction_receipt_by_hash
signature, to avoid copying of the input param.get_block_with_receipts
.starknet_traceBlockTransactions
to return Vec instead of an object, because it adds additional traces property to the serialized object.starknet_getBlockWithReceipts
from testing the json request/response, because we use the transaction object in the response which contains the transaction hash, but in the RPC spec this property is omitted. Also the spec is not released yet and its format maybe can change. Also requires refactoring to exclude the transaction_hash from already saved Transactions Refactor Transaction enum #363Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
cargo test