Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing data gas price in rpc endpoints #392

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Missing data gas price in rpc endpoints #392

merged 3 commits into from
Mar 26, 2024

Conversation

marioiordanov
Copy link
Contributor

Usage related changes

An issue reported that starknet_getBlockWithReceipts return 0 for data_gas_price.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@marioiordanov marioiordanov marked this pull request as ready for review March 21, 2024 16:27
@marioiordanov marioiordanov merged commit 8aa392b into main Mar 26, 2024
1 check passed
@marioiordanov marioiordanov deleted the missing_data_gas_price branch March 26, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marioiordanov @FabijanC