Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix starknet_getClassAt in forked mode #421

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Fix starknet_getClassAt in forked mode #421

merged 4 commits into from
Apr 15, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 12, 2024 •
edited
Loading

Usage related changes

Development related changes

  • Expand test_getting_cairo1_class_from_origin_and_fork in test_fork.rs to include get_class_at assertion

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC marked this pull request as ready for review April 15, 2024 09:44
@FabijanC FabijanC merged commit ae8e752 into main Apr 15, 2024
1 check passed
@FabijanC FabijanC deleted the fix-get-class-at-forked branch April 15, 2024 10:08
@FabijanC FabijanC mentioned this pull request Apr 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract not found error when forking
2 participants
@FabijanC @marioiordanov