Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block on demand #430

Merged
merged 57 commits into from
Apr 26, 2024
Merged

Block on demand #430

merged 57 commits into from
Apr 26, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Apr 16, 2024 •
edited
Loading

Usage related changes

  • add block on demand feature
  • dump/load transaction mode was renamed to block mode

Development related changes

  • pending_state in Starknet was added

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

Mikołaj Woźniak added 8 commits April 11, 2024 08:17
Add blocks_on_demand CLI
b5423bb 
[skip ci]
Update cli.rs
7a2caf5 
[skip ci]
Merge branch 'main' into block-on-demand
90833c9
first test - blocks_on_demand
e39ec48 
[skip ci]
Update test_blocks_on_demand.rs
0ac581b 
[skip ci]
Update mod.rs
b608247 
[skip ci]
semi MVP version
b6f044f 
there is still problem with self.state = self.pending_state.clone_historic in create block

[skip ci]
MVP version of block on demand
2c8fb17
@mikiw mikiw marked this pull request as draft April 16, 2024 14:37
Mikołaj Woźniak added 4 commits April 17, 2024 12:21
@mikiw
Copy link
Contributor Author

mikiw commented Apr 18, 2024

as @FabijanC suggested we could change dump mode from transaction to block which makes more sense

@mikiw mikiw linked an issue Apr 18, 2024 that may be closed by this pull request
Create a block on demand #312
Closed
@ivpavici ivpavici linked an issue Apr 19, 2024 that may be closed by this pull request
Inconsistent with starknet-spec responses #381
Closed
1 task
@mikiw mikiw mentioned this pull request Apr 22, 2024
Closed
1 task
@mikiw mikiw removed a link to an issue Apr 22, 2024
Inconsistent with starknet-spec responses #381
Closed
1 task
@mikiw mikiw marked this pull request as ready for review April 22, 2024 13:21
@mikiw mikiw requested a review from FabijanC April 22, 2024 14:30
Update README.md
fa9d498 
[skip ci]
@mikiw
Copy link
Contributor Author

mikiw commented Apr 25, 2024

Add logic and test for querying pending block with normal mode

added in 35be702

@mikiw mikiw mentioned this pull request Apr 25, 2024
Closed
@mikiw mikiw requested a review from FabijanC April 25, 2024 14:40
FabijanC
FabijanC requested changes Apr 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/api/json_rpc/endpoints.rs Outdated Show resolved Hide resolved
@mikiw mikiw merged commit 81e9abb into main Apr 26, 2024
1 check passed
@mikiw mikiw deleted the block-on-demand branch April 26, 2024 14:17
@FabijanC FabijanC mentioned this pull request Aug 16, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a block on demand
2 participants
@mikiw @FabijanC