Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix predeployed account constructor simulation #431

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Fix predeployed account constructor simulation #431

merged 8 commits into from
Apr 18, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 16, 2024 •
edited
Loading

Usage related changes

Development related changes

  • Extract constructor simulation logic of predeployed accounts to simulate_constructor.
  • Deliberately using two constants for ISRC6_ID_HEX, one in production, the other in testing.
  • Reuse account deployment logic in tests (deploy_account utility function).

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC changed the title Fix predeployed acc Fix insufficient account constructor simulation Apr 16, 2024
@FabijanC FabijanC changed the title Fix insufficient account constructor simulation Fix predeployed account constructor simulation Apr 18, 2024
@FabijanC FabijanC marked this pull request as ready for review April 18, 2024 08:59
mikiw
mikiw reviewed Apr 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
@FabijanC FabijanC merged commit 028bd95 into main Apr 18, 2024
@FabijanC FabijanC deleted the fix-predeployed-acc branch April 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Predeployed account not supporting interface ID of OZ 0.8.1, subsequent deployed accounts support
2 participants
@FabijanC @mikiw