Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change balance amount type to String #432

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Change balance amount type to String #432

merged 3 commits into from
Apr 18, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 18, 2024 •
edited
Loading

Usage related changes

Development related changes

  • Introduce new test file: test_balance.rs
    • Include one old test in it: getting_balance_of_predeployed_contract

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

mikiw
mikiw approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on a call it seems like a good way to go, also others APIs in crypto industry use Strings in BigInt

@FabijanC FabijanC merged commit 9162df9 into main Apr 18, 2024
@FabijanC FabijanC deleted the fix-acc-balance-resp branch April 18, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikiw mikiw mikiw approved these changes

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

account_balance format
3 participants
@FabijanC @mikiw @marioiordanov