Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce config endpoint #433

Merged
merged 14 commits into from
Apr 24, 2024
Merged

Introduce config endpoint #433

merged 14 commits into from
Apr 24, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 18, 2024

Usage related changes

  • Close Fetch devnet Configuration #428
    • Add endpoint GET /config for retrieving the current Devnet configuration. The response can be understood as the mapping of CLI parameters (specified and default ones) in JSON format, with some irrelevant parameters omitted. See README.md changes for an example.
  • Remove endpoint GET /fork_status as its response has become a part of the new endpoint's response.

Development related changes

  • port of BackgroundDevnet exposed for testing purpose.
  • HttpApiHandler now including server_config property for the purpose of including it in the config response.
  • Use serde(rename_all = ...) and clap(rename_all = ...) where possible.

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC marked this pull request as ready for review April 19, 2024 14:27
Copy link

@qperrot qperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code tested locally with different options set.

@FabijanC FabijanC changed the title Config endpoint Introduce config endpoint Apr 24, 2024
@FabijanC FabijanC merged commit ed53233 into main Apr 24, 2024
1 check passed
@FabijanC FabijanC deleted the config-endpoint branch April 24, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch devnet Configuration
3 participants