-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cairo lang errs #435
cairo lang errs #435
Conversation
@marioiordanov is this what you meant (I took sierra errors from cairo_lang_starknet_classes, as cairo_lang_starknet had just abi errors in it) ? I have also not removed the "reason" property, let me know if you want it removed. |
@lordshashank just make it as |
@marioiordanov
Now, I tried to use |
@lordshashank take a look at other error variants that have the same structure |
@marioiordanov , I have looked into the other variants, thing is StarknetSierraCompilationError has many variants here,
or should I use some specific variant only? |
@lordshashank sorry about misleading you, just add a String to the SierraCompilationError variant and then create the variant like this: Error::SierraCompilationError(err_str) |
@marioiordanov I don't understand, do you want StarknetSierraCompilationError Error derivation for SierraCompilationError to be removed here and just make variant from string message, if thats the case, it is already like that in repo's current state, then what changes do we intend to do in the issue? |
I just saw that there are two SierraCompilationError variants in different crates. Replace usage of SierraCompilationError variant from starknet_devnet_core::errors::Error with TypesError(starknet_devnet_types::error::Error::SierraCompilationError). Then delete the variant from starknet_devnet_core |
@marioiordanov did that, let me know if something else is to be done here. |
@marioiordanov should we change issue description if this is all to be done? |
@lordshashank we will just make a comment. Have to run the CI to approve your PR |
Ok let me know if CI fails. |
Usage related changes
improves error handling
Development related changes
Resolves #198
Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh