Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account impersonation #436

Merged
merged 37 commits into from
May 21, 2024
Merged

Account impersonation #436

merged 37 commits into from
May 21, 2024

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Apr 23, 2024

Usage related changes

Added 4 methods following JSON-RPC spec.
Closes #407

Development related changes

Added checks for impersonated accounts in DECLARE and INVOKE handler methods.
Added integration tests for account impersonation.

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@marioiordanov marioiordanov marked this pull request as ready for review April 23, 2024 07:00
README.md Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/cheats.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/common/background_devnet.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/common/background_devnet.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/common/utils.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_account_impersonation.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_account_impersonation.rs Outdated Show resolved Hide resolved
@marioiordanov marioiordanov merged commit de07790 into main May 21, 2024
1 check passed
@marioiordanov marioiordanov deleted the impersonate branch May 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account impersonating
2 participants