Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add memory performance tests #439

Merged
merged 17 commits into from
May 7, 2024
Merged

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Apr 23, 2024

Usage related changes

None

Development related changes

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

makefile Outdated Show resolved Hide resolved
@hhamud hhamud marked this pull request as ready for review April 24, 2024 23:27
@hhamud hhamud requested a review from FabijanC April 24, 2024 23:27
@FabijanC FabijanC requested a review from mikiw April 25, 2024 13:08
@mikiw
Copy link
Contributor

mikiw commented Apr 25, 2024

I'll try to check it today

Cargo.toml Show resolved Hide resolved
crates/starknet-devnet/tests/benches/mint_bench.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/Cargo.toml Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/benches/mint_bench.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

measuring memory inside this test would be helpful but if it's not possible or really hard we can skip that

crates/starknet-devnet/tests/benches/mint_bench.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/benches/mint_bench.rs Outdated Show resolved Hide resolved
@hhamud hhamud requested review from FabijanC and mikiw April 28, 2024 23:13
crates/starknet-devnet/benches/mint_bench.rs Show resolved Hide resolved
crates/starknet-devnet/tests/common/utils.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/benches/mint_bench.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/benches/mint_bench.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
crates/starknet-devnet/tests/test_memory_test.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_memory_test.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_memory_test.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_memory_test.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_memory_test.rs Outdated Show resolved Hide resolved
@hhamud hhamud requested a review from FabijanC April 29, 2024 13:15
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect that this memory measurement inside Rust test would be problematic but seems that it is.

I added my review of how I see it to be mergeable.

crates/starknet-devnet/benches/mint_bench.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/benches/mint_bench.rs Outdated Show resolved Hide resolved
@hhamud hhamud requested a review from mikiw May 6, 2024 16:42
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm retracting my Approval, there is still some investigation going on.

@FabijanC FabijanC merged commit 6fc953d into 0xSpaceShard:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add memory performance tests
3 participants