Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 387, Set gas price #448

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Issue 387, Set gas price #448

merged 6 commits into from
Apr 29, 2024

Conversation

Hueber9500
Copy link
Contributor

@Hueber9500 Hueber9500 commented Apr 26, 2024 •
edited by FabijanC
Loading

Usage related changes

  • Closes Set gas price #387
  • Added new CLI params:
    • --gas-price-strk <STRK>
    • --data-gas-price-strk <STRK>

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@marioiordanov
Copy link
Contributor

In the readme section there is an example of devnet configuration response. Please update it to reflect the changes

marioiordanov
marioiordanov reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, will run the CI

@marioiordanov
Copy link
Contributor

There is an error from clippy. Just add clippy too_many_arguments

@Hueber9500
Copy link
Contributor Author

I added it

@marioiordanov
Copy link
Contributor

before each push, run the scripts: format.sh and clippy_check.sh

@Hueber9500
Copy link
Contributor Author

Pushed new changes

@marioiordanov marioiordanov merged commit 2fc753b into 0xSpaceShard:main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set gas price
2 participants
@Hueber9500 @marioiordanov