Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing and contributing #454

Merged
merged 10 commits into from
May 3, 2024
Merged

Improve testing and contributing #454

merged 10 commits into from
May 3, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 30, 2024

Usage related changes

  • None

Development related changes

  • Remove redundant artifact - replaced with utility function
  • Minimize a sierra artifact
  • Improve contribution guidelines (should have been done before OD Hack, but better late than never)
  • Improve Background{Devnet,Anvil}:
    • Use shorter for loop instead of while
    • Reuse client used for connection checking

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC marked this pull request as ready for review April 30, 2024 14:55
README.md Outdated Show resolved Hide resolved
@FabijanC FabijanC requested a review from ivpavici May 3, 2024 15:04
@FabijanC FabijanC merged commit e04b7cd into main May 3, 2024
@FabijanC FabijanC deleted the test-maintenance branch May 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants