Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging request and responses #455

Merged
merged 20 commits into from
May 16, 2024
Merged

Logging request and responses #455

merged 20 commits into from
May 16, 2024

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Apr 30, 2024

Usage related changes

User now can pass environment variable: RUST_LOG="request,response" and the body of http requests and responses will be outputted

Development related changes

Added 2 layers: logging requests body and logging response body

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@marioiordanov marioiordanov marked this pull request as ready for review May 1, 2024 07:04
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature and tests, but I left some comments

crates/starknet-devnet-server/src/builder.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/builder.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
crates/starknet-devnet-server/src/builder.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
crates/starknet-devnet/src/main.rs Outdated Show resolved Hide resolved
@marioiordanov marioiordanov merged commit 69f183a into main May 16, 2024
1 check passed
@marioiordanov marioiordanov deleted the logging branch May 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag that would have it dump request & response payloads to stdout.
2 participants