Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of get_block_with_txs and get_block_with_receipts for peding blocks #466

Merged
merged 6 commits into from
May 13, 2024
Merged

Update of get_block_with_txs and get_block_with_receipts for peding blocks #466

merged 6 commits into from
May 13, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented May 10, 2024 •
edited
Loading

Usage related changes

  • Update of get_block_with_txs and get_block_with_receipts for pending blocks

Development related changes

  • refactor of business logic related to self.config.blocks_on_demand

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@mikiw mikiw marked this pull request as draft May 10, 2024 12:21
@mikiw
Copy link
Contributor Author

mikiw commented May 13, 2024

This PR is addressing @marioiordanov find outs from #461

@mikiw mikiw marked this pull request as ready for review May 13, 2024 12:32
@mikiw mikiw requested a review from marioiordanov May 13, 2024 13:15
@mikiw mikiw merged commit 1c9eb9e into main May 13, 2024
1 check passed
@mikiw mikiw deleted the block-spec-update-2 branch May 13, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikiw @marioiordanov