Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve account class testing #476

Merged
merged 2 commits into from
May 31, 2024
Merged

Improve account class testing #476

merged 2 commits into from
May 31, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented May 31, 2024

Usage related changes

  • None

Development related changes

  • Include cairo0 and cairo1 contract interaction in account class testing.
  • Remove explicit providing of nonce and max_fee (now implicitly estimated), so that the util function can be reused between tests.
  • Expand assert_tx_successful to include finality status assertion.
  • Change the return value of the deploy_account util function to include the signer (needed in some test cases).
  • Reduce line count by extracting BackgroundDevnet CLI args to a separate line.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC changed the title Improve account deployment Improve account class testing May 31, 2024
@FabijanC FabijanC merged commit 245c0d6 into main May 31, 2024
1 check passed
@FabijanC FabijanC deleted the improve-account-deployment branch May 31, 2024 09:19
@FabijanC FabijanC mentioned this pull request Jun 3, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants