Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CLI parameter specification via env vars #483

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Jun 4, 2024

Usage related changes

Development related changes

  • Enable the env feature of the clap dependency in Cargo.toml.
  • Introduces serial_test dev dependency because env-mainpulating tests cannot be run in parallel.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC marked this pull request as ready for review June 5, 2024 11:50
Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if cli args and env variables are passed

@FabijanC
Copy link
Contributor Author

FabijanC commented Jun 6, 2024

What will happen if cli args and env variables are passed

I thought I added this info, thanks for reminding me. Updated the docs in e268e43

@FabijanC FabijanC merged commit c897241 into main Jun 6, 2024
@FabijanC FabijanC deleted the params-via-env-vars branch June 6, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants