Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling account impersonation #488

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Support disabling account impersonation #488

merged 5 commits into from
Jun 10, 2024

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Jun 10, 2024 •
edited
Loading

Usage related changes

User can specify to disable account impersonation by:
cli flag --disable-account-impersonation
env var DISABLE_ACCOUNT_IMPERSONATION

Development related changes

  • Added cli flag
  • Added integration test

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@marioiordanov marioiordanov marked this pull request as ready for review June 10, 2024 06:53
@FabijanC FabijanC self-requested a review June 10, 2024 07:27
FabijanC
FabijanC requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had some documentation comments, otherwise good to go.

website/docs/account-impersonation.md Outdated Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Outdated Show resolved Hide resolved
@FabijanC FabijanC changed the title Disable impersonate account Support disabling account impersonation Jun 10, 2024
@FabijanC FabijanC merged commit 93317d6 into main Jun 10, 2024
1 check was pending
@FabijanC FabijanC deleted the disable-impersonate branch June 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marioiordanov @FabijanC