Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block generation period #491

Merged
merged 48 commits into from
Jun 18, 2024
Merged

Block generation period #491

merged 48 commits into from
Jun 18, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Jun 12, 2024 •
edited
Loading

Usage related changes

  • --blocks-on-demand functionality is changed to --block-generation-on <transaction|demand|<SECONDS>

Development related changes

  • now server is spawned with task::spawn and via into_future() along with create_block_interval() task when --block-generation-on <SECONDS> to handle ctrl c signal properly
  • mod blocks_on_demand_tests needed a rename to mod blocks_generation_tests along with filename

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

Mikołaj Woźniak added 21 commits June 3, 2024 16:24
pending_state refactor
f72fc13
use starknet.pending_state
03e79a0
Update mod.rs
c701a02 
[skip ci]
update tests
953f9f8
Fix block on demand test
7910c4d
fix abort_block_state_revert test
7a5c7b5
Add get_nonce_of_first_predeployed_account
4033e8a
Update blocks.md
027d3b2 
[skip ci]
Merge branch 'main' into get-nonce-fix
aecaf78
update test
9d3e256
Update test_blocks_on_demand.rs
f7c2357
rename blocks_on_demand to block_generation
b6c9aa7 
[skip ci]
rename ON_DEMAND to on_demand
c9189ad
Fix tests
6ef93af
Merge branch 'main' into block-generation-period
71d8b4f
Adapt to --block-generation-on demand
5636895
remove optional in block_generation
5e37136
Merge branch 'main' into block-generation-period
3453d84
add periodic_task problem
b59553f 
[skip ci]
Add BlockGeneration::Interval
03783e8 
[skip ci]
apply formatting
4525c53 
[skip ci]
@mikiw mikiw marked this pull request as draft June 12, 2024 11:18
@mikiw mikiw linked an issue Jun 12, 2024 that may be closed by this pull request
Add mining blocks at a certain interval #467
Closed
@mikiw mikiw marked this pull request as ready for review June 12, 2024 14:42
@mikiw mikiw requested a review from FabijanC June 12, 2024 19:20
FabijanC
FabijanC requested changes Jun 13, 2024
View reviewed changes
crates/starknet-devnet-server/src/api/http/endpoints/mint_token.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/src/cli.rs Outdated Show resolved Hide resolved
website/versioned_docs/version-0.0.6/api.md Outdated Show resolved Hide resolved
website/docs/blocks.md Show resolved Hide resolved
website/docs/dump-load-restart.md Show resolved Hide resolved
crates/starknet-devnet/src/main.rs Show resolved Hide resolved
crates/starknet-devnet/src/main.rs Show resolved Hide resolved
crates/starknet-devnet/tests/test_blocks_generation.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_blocks_generation.rs Show resolved Hide resolved
crates/starknet-devnet/tests/test_blocks_generation.rs Show resolved Hide resolved
Mikołaj Woźniak added 19 commits June 14, 2024 12:46
rename timestamp to seconds
f161834 
[skip ci]
rename BlockGeneration to BlockGenerationOn
f8802ab 
[skip ci]
Add error propagation
7b31780
add formatting
6741c29
add generating block on time interval info
e07f02f 
[skip ci]
rename UniqueAutoDeletableFile
7fdd5f4 
[skip ci]
rename UniqueAutoDeletableFile
54396d5 
[skip ci]
Add blocks_on_interval_transactions
6a42221
change arg help
3fcfd34 
[skip ci]
Update mint_token.rs
619a440
revert of 0.0.6 doc
48f3828 
[skip ci]
Add of Automatic periodic block creation
30ecabb 
[skip ci]
Add cli block-generation-on tests
c1290f7
use try_join
4c2d1d9
Revert "use try_join"
bf85700 
This reverts commit 4c2d1d9.
Revert "Revert "use try_join""
0ebca85 
This reverts commit bf85700.
use join_all
6008680
apply formatting
1ea8817
Merge branch 'main' into block-generation-period
77d6f20
@mikiw mikiw requested a review from FabijanC June 18, 2024 12:04
@mikiw mikiw merged commit 24ed52d into main Jun 18, 2024
1 check passed
@mikiw mikiw deleted the block-generation-period branch June 18, 2024 13:58
@FabijanC FabijanC mentioned this pull request Jul 3, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mining blocks at a certain interval
2 participants
@mikiw @FabijanC