Fix RPC error on starknet_getBlockTransactionCount #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
requested changes
Jun 17, 2024
There was a problem hiding this comment.
There are unchecked checkboxes in the PR description. If your PR is not yet reviewable, convert it to draft. I agree that the change you made is needed, but the tests for sure need to be updated:
- If there were tests checking if
NoBlocksis returned, they should be changed to checkingBlockNotFoundis returned) - If there were no tests for this case, they need to be added.
|
@tonypony220 how is it going? should someone else take over? |
|
@FabijanC in progress, are you in rush for resolving this? |
Ok! Not in a rush, just want to prevent this from becoming stale. |
tonypony220
force-pushed
the
fix_get_block_txs_count_error
branch
from
9a40ad3
to
951e57a
Compare
FabijanC
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
resolves #496
Development related changes
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md