-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify rpc #500
Unify rpc #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Should we eventually document all JSON-RPC methods and parameters in a specification .json file, like Starknet does? We would then not include JSON-RPC examples in these .md documentation files, but would just link to the specification .json.
-
What about testing? My idea is to convert all tests that relied on HTTP methods to rely on JSON-RPC methods. That would be in line with deprecating these HTTP methods and dropping their support in 2-3 months. For integration tests, it would include changing the utility methods to change the sent requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the question from my first review:
Should we eventually document all JSON-RPC methods and parameters in a specification .json file, like Starknet does?
I guess for now it stays as it is.
Thanks for addressing the change requests. Approving.
For new JSON-RPC there is an issue created: #508 |
Usage related changes
Users can use http api endpoints via JSON-RPC api.
Development related changes
<http api endpoint>_impl
function which is called from JSON-RPC counterpartChecklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
./scripts/check_spelling.sh
./website/README.md