Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calling commit_with_diff from generate_new_block_and_state #503

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Remove calling commit_with_diff from generate_new_block_and_state #503

merged 2 commits into from
Jun 19, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Jun 19, 2024 •
edited
Loading

Usage related changes

  • remove of self.commit_with_diff

Development related changes

  • additional test for remove of self.commit_with_diff is not needed sinceblocks_on_demand_states_and_blocks() test is checking that scenario

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@mikiw mikiw linked an issue Jun 19, 2024 that may be closed by this pull request
Check commit_with_diff() inside generate_new_block_and_state() #501
Closed
@mikiw mikiw requested a review from FabijanC June 19, 2024 08:11
@FabijanC FabijanC changed the title remove of self.commit_with_diff Remove calling commit_with_diff from generate_new_block_and_state Jun 19, 2024
@mikiw mikiw merged commit 3ec7aab into main Jun 19, 2024
1 check passed
@mikiw mikiw deleted the remove-of-commit-diff branch June 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check commit_with_diff() inside generate_new_block_and_state()
2 participants
@mikiw @FabijanC