Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix starknet_getEvents returning wildcard error on nonexistent block #509

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

tonypony220
Copy link
Contributor

@tonypony220 tonypony220 commented Jun 22, 2024

Usage related changes

fix #498

Development related changes

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

crates/starknet-devnet-core/src/messaging/ethereum.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_get_events.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_get_events.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_get_events.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_get_events.rs Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 48c4705 into 0xSpaceShard:main Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starknet_getEvents returning wildcard error on nonexistent block
2 participants