Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https instead of http #524

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Use https instead of http #524

merged 2 commits into from
Jul 1, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Jul 1, 2024 •
edited
Loading

Development related changes

  • use https instead of HTTP in forking tests

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@mikiw mikiw requested a review from FabijanC July 1, 2024 09:37
@mikiw mikiw changed the title use https instead of http Use https instead of http Jul 1, 2024
FabijanC
FabijanC approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mikiw mikiw merged commit 84e1339 into main Jul 1, 2024
1 check passed
@mikiw mikiw deleted the https-fork-test-fix branch July 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikiw @FabijanC