Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a map appends '-merc' suffix to map name. #204

Closed
bovender opened this issue Jan 19, 2016 · 2 comments
Closed

Creating a map appends '-merc' suffix to map name. #204

bovender opened this issue Jan 19, 2016 · 2 comments
Labels
Bug Report Map File

Comments

@bovender
Copy link

When maps are created by the create/jqvmap.py script, a suffix -merc is automatically appended to the map name in the resulting javascript file. Of course the maps won't load if the name originally given in the json config file is used.

I saw this with two maps I created. After manually removing the -merc suffix, I could load the maps all right of course.

Is this a bug or some feature, am I missing something?
@manifestinteractive
Copy link
Contributor

This is likely how the map file is named and I just forgot to remove the suffix. There is some code in there thats adding it, so simply removing the suffix should do the trick. It might be a few days before I can look into this myself, but in the mean time, removing the suffix as you stated will solve the issue.

@bovender
Copy link
Author

bovender commented Feb 5, 2016

Thanks, I suspected as much. If I had time myself, I'd come up with a patch myself...

manifestinteractive added a commit that referenced this issue Mar 16, 2016
@manifestinteractive
1. Updated LICENSE path in packaged dist files
a53a51e 
2. Fixed bugs in labels and pins where mouse events were not passing through to clickable region
3. Removed -merc suffix from map files created by map creator ( fixes #204 )
4. Added new example for custom placement of pins `./examples/pins_custom.html`
5. Fixed `onRegionSelect` issue not returning region ( fixes #201 )
6. Added better support to make regions disabled ( see #197 and new `./examples/inactive_regions.html` )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Map File
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manifestinteractive @bovender