Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #269 by adding setSelectedRegions function #271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ethanclevenger91
Copy link

@ethanclevenger91 ethanclevenger91 commented Nov 29, 2016

What does this PR do ?

Adds expected setSelectedRegions function and uses it on initialization. Also updated grunt tasks to work on Windows machine, see here. Caught bower version up to npm version. Unsure if that was an intentional discrepency?

How should this be tested ?

Confirm existing tests pass (they do). I did not write a test for this particular function, however. Can be confirmed in browser by utilizing.

What are the relevant issues ?

#269 (and this StackOverflow question)

This Pull Request includes:

  • Bug Fix with passing npm test
  • New Feature with passing npm test
  • Code Improvement with passing npm test
  • Updated Documentation
  • New Map File & Example HTML

What gif best describes how you feel about this work ?

giphy

@ethanclevenger91
Copy link
Author

Btw - I marked this as patch rather than minor b/c the documentation implies this functionality already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant