Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/selected border color #344

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xoxefdp
Copy link

@xoxefdp xoxefdp commented Jul 6, 2019

What does this PR do ?

adds a parameter that enables region border to change when onRegionSelect or onRegionDeselect occurs if parameter not null

How should this be tested ?

adding selectedBorderColor: #color / rgba( color, opacity ) to jqvmap selector object, check border color changes when region selects and deselects

What are the relevant issues ?

None, it is a feature

This Pull Request includes:

  • Bug Fix with passing npm test
  • New Feature with passing npm test
  • Code Improvement with passing npm test
  • Updated Documentation
  • New Map File & Example HTML

FYI tests didn't pass even in original master branch

What gif best describes how you feel about this work ?

not_bad_meme

@xoxefdp xoxefdp force-pushed the feature/selected-border-color branch from 3a58d0e to 3375f40 Compare March 28, 2021 11:17
@xoxefdp xoxefdp force-pushed the feature/selected-border-color branch from 0b342bd to 532f0ba Compare March 28, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant