Support char type #128
Support char type #128
Conversation
czocher
force-pushed
the
support-char-type
branch
from
2085702
to
07d46ea
Compare
czocher
force-pushed
the
support-char-type
branch
from
07d46ea
to
6325466
Compare
|
Looks great, just a small Swift nit and it's good to merge |
|
@Lucretiel already fixed ;). |
|
I'm not seeing it on the PR; does it need to be pushed? |
@Lucretiel You mean the change requested by @CerulanLumina? I amended the change just after they noticed it. This is the current version that shows up when I check the changes in this PR: https://github.com/1Password/typeshare/pull/128/files#diff-e3f812823b9b43de87bbd7c54ab61d3e102c387d74245c65cd8a0e3bbca2193e, is there some other thing I missed? |
|
Whoops, it was I who didn't didn't press Push on my review and just let it sit as a draft |
czocher
force-pushed
the
support-char-type
branch
from
6325466
to
e48a60a
Compare
|
@Lucretiel done! |
czocher
force-pushed
the
support-char-type
branch
from
e48a60a
to
a8b7215
Compare
|
Looks good! Just need the commit to pass signing then we'll merge! |
czocher
force-pushed
the
support-char-type
branch
from
a8b7215
to
edb16b1
Compare
|
There was some weird mixup with my GitHub account configuration, reuploaded my GPG key and it seems to work. Thanks! |
Add support for the Rust
chartype.Closes #103