-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force Rust 1.57 MSRV #129
Force Rust 1.57 MSRV #129
Conversation
206d180
to
6b262e5
Compare
@CerulanLumina what do we do about the |
Clippy on stable should be fine. Any MSRV issues should be caught by the rest of the toolchain, and it seems using an updated clippy should only allow the extra indirection we have in Thanks for working this, we appreciate your contributions! |
c80110f
to
cd4879d
Compare
I changed it to validate with |
Thanks for the contribution! I'm worried about forcing all uses of this library to use 1.57, even local development builds (as opposed to using it only as part of a CI matrix). I'll ask the rest of the typeshare team and get back to you. |
@Lucretiel I implemented the dev change due to the task mentioned in #94, but if that's not necessary I can remove the local dev part of this PR ;). |
I spoke with the team and apparently I was just mistaken, these changes look good! I'm giving it a final lookover then we should be able to merge today |
6d55389
to
7bae69c
Compare
Thanks! |
This PR forces the CI as well as local dev environments to use Rust
1.57
, which is the MSRV for this project.Closes #94