Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support smart pointers #134

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Support smart pointers #134

merged 4 commits into from
Oct 25, 2023

Conversation

LuminaSapphira
Copy link
Collaborator

Serde supports transparently (de)serializing many Rust std smart pointers, such as Cow, Rc, Arc, Cell, and others. This expands our automatic Box to inner T mapping with these additional types.

Note: Looking for reviews from language pros to validate output. View the snapshot tests for details.

Resolves #133

@LuminaSapphira LuminaSapphira added the question Further information is requested label Jul 13, 2023
@LuminaSapphira LuminaSapphira self-assigned this Jul 13, 2023
Copy link
Contributor

@Lucretiel Lucretiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me once the tests pass

@LuminaSapphira
Copy link
Collaborator Author

@Lucretiel I was confused since these errors were occurring in files I didn't touch. They are also in main, I think from MSRV changes.

@LuminaSapphira
Copy link
Collaborator Author

Fixed by #135

@Lucretiel
Copy link
Contributor

Just needs a cargo fmt and a rebase and it's ready to merge

@snowsignal snowsignal force-pushed the CerulanLumina/133-smart-pointers branch from 3a89bd1 to ccfade3 Compare October 25, 2023 03:05
@snowsignal snowsignal merged commit c3ee2ad into main Oct 25, 2023
8 checks passed
@snowsignal snowsignal deleted the CerulanLumina/133-smart-pointers branch October 25, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cow is not handled correctly
3 participants