Multiple file output #166

darrell-roberts · 2024-04-14T16:02:33Z

Solution to #71

Adds option to generate multiple modules per source crate.

Supports imports for multiple modules

Typescript
Kotlin
Swift

Updates package declarations for

Kotlin

Ex:

typeshare ~/projects/core --lang typescript --output-folder ~/projects/core/new-types/src --config-file ~/projects/core/typeshare.toml

mdbook build action should not have to use MSRV

Update toolchain for deploy documentation

Update rust lang actions

LuminaSapphira

Note: This is a partial review, leaving the following comments. Will return.

.clippy.toml

README.md

cli/src/args.rs

cli/src/config.rs

cli/src/main.rs

LuminaSapphira

Part 2/2 of review: overall great, some minor notes

core/src/language/go.rs

core/src/language/mod.rs

core/src/language/swift.rs

core/src/language/mod.rs

LuminaSapphira

Thank you for your hard work on this!

LuminaSapphira · 2024-05-01T16:41:00Z

One request: would you mind rebasing to squash some commits for a cleaner history?

There's also some merge conflicts that need resolving before I can merge.

Thanks again, and we'll get this merged this week!

…e changed.

…le with multi-file.

darrell-roberts added 5 commits April 2, 2024 17:37

Merge pull request #1 from darrell-roberts/fix-mdbook

b6784f4

mdbook build action should not have to use MSRV

Merge pull request #2 from darrell-roberts/fix-mdbook

f54ded3

Update toolchain for deploy documentation

Merge pull request #3 from darrell-roberts/fix-mdbook

31d6f8e

Update rust lang actions

Merge branch '1Password:main' into main

fb1f847

Merge branch '1Password:main' into main

1a30c5e

darrell-roberts force-pushed the multi-file-output branch from a0c0ad9 to a2370f6 Compare April 14, 2024 16:05

darrell-roberts mentioned this pull request Apr 14, 2024

Allow generated types to be namespaced #71

Open

Merge branch '1Password:main' into main

4b571f8

darrell-roberts force-pushed the multi-file-output branch 5 times, most recently from 28faf5e to 482ef87 Compare April 17, 2024 19:21

LuminaSapphira requested changes Apr 18, 2024

View reviewed changes

.clippy.toml Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

cli/src/args.rs Outdated Show resolved Hide resolved

cli/src/config.rs Show resolved Hide resolved

cli/src/main.rs Outdated Show resolved Hide resolved

LuminaSapphira requested changes Apr 19, 2024

View reviewed changes

terror mentioned this pull request Apr 26, 2024

Integrate typeshare to reduce client-side toil terror/mcgill.courses#541

Draft

LuminaSapphira approved these changes May 1, 2024

View reviewed changes

darrell-roberts and others added 12 commits May 1, 2024 12:42

Merge branch '1Password:main' into main

087fec6

Generate multiple output files

81e93eb

Mutli file generation with imports inserted

07ebc60

Update unit test

4513f10

Add import exclusions

0e2b18c

Update all type collection

c80a4ea

Keep imports sorted so output is stable when checking if contents hav…

511fb14

…e changed.

Cleanup

d2112f1

Refactor used imports

7fe2611

Avoid cloning when building used imports

1b0b10a

Cleanup

0fc81d7

Update import visitor to accept types and not functions

5b8e6ad

darrell-roberts added 27 commits May 1, 2024 12:49

Bump deps. Ignore remapped files for kotlin import lookup.

53f703e

Add code comment

d1a987e

Swift file names and imports

f3db449

Add docs to public trait

552f748

Disable imports for swift for now. Write CodableVoid to separate modu…

7ec1b1b

…le with multi-file.

Refactor write codable void.

f96492e

Update msrv to 1.77

cd35d85

File should be open as read only

314b49f

Update deps

54fff44

downgrade to 1.75 for nix build

90a8524

Attempt to fix nix build

d637f76

cleanup

505eef8

update to use anyhow macro

4049dad

Update argument parsing for unique output options (file/folder)

8561083

Bump toml dep. Put back 1.75 MSRV.

ec5a987

Cleanup

f2d0428

Cleanup

a082ea5

Rename for clarity

a28ab38

Use a &str over String

cb08c48

Cleanup

ad32939

Remove default impl for write_imports

ff56a1f

Use else if over continue

ff18763

Use File::create and reduce allocations with PathBuf

ec4efa6

Remove cloning

fda718b

cleanup

d9cde67

cleanup

9f74ff0

Update to rust stable

baa19ab

darrell-roberts force-pushed the multi-file-output branch from 7ded536 to baa19ab Compare May 1, 2024 16:51

LuminaSapphira merged commit 11ef8a8 into 1Password:main May 1, 2024
5 checks passed

darrell-roberts deleted the multi-file-output branch June 7, 2024 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple file output #166

Multiple file output #166

darrell-roberts commented Apr 14, 2024 •

edited

Loading

LuminaSapphira left a comment

LuminaSapphira left a comment

LuminaSapphira left a comment

LuminaSapphira commented May 1, 2024

Multiple file output #166

Multiple file output #166

Conversation

darrell-roberts commented Apr 14, 2024 • edited Loading

LuminaSapphira left a comment

Choose a reason for hiding this comment

LuminaSapphira left a comment

Choose a reason for hiding this comment

LuminaSapphira left a comment

Choose a reason for hiding this comment

LuminaSapphira commented May 1, 2024

darrell-roberts commented Apr 14, 2024 •

edited

Loading