Add Typeshare support for Python #169
Open
+875
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to the prior work of @adriangb: 1Password#25
Lucretiel
reviewed
Jun 4, 2024
| @@ -14,6 +14,9 @@ thiserror = "1" | |||
| itertools = "0.12" | |||
| lazy_format = "2" | |||
| joinery = "2" | |||
| topological-sort = { version = "0.2.2"} | |||
| once_cell = { version = "1"} | |||
There was a problem hiding this comment.
Use the built-in oncelock https://doc.rust-lang.org/std/sync/struct.OnceLock.html
Lucretiel
reviewed
Jun 4, 2024
core/src/language/python.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| enum ParsedRusthThing<'a> { |
Lucretiel
reviewed
Jun 4, 2024
core/src/language/python.rs
Outdated
| /// Mappings from Rust type names to Python type names | ||
| pub type_mappings: HashMap<String, String>, | ||
| /// The Python module for the generated code. | ||
| pub module: RefCell<Module>, |
Lucretiel
reviewed
Jun 4, 2024
| module.add_global(identifier, vec![id.clone()]) | ||
| } | ||
| RustType::Simple { id } => module.add_global(identifier, vec![id.clone()]), | ||
| RustType::Special(_) => {} |
There was a problem hiding this comment.
Type aliases for special types are unsupported?
Lucretiel
reviewed
Jun 4, 2024
core/src/language/python.rs
Outdated
| | SpecialRustType::I64 | ||
| | SpecialRustType::ISize | ||
| | SpecialRustType::USize => { | ||
| panic!("64 bit types not allowed in Typeshare") |
There was a problem hiding this comment.
They're supported by python, though, so I'm not seeing any reason to fail here.
|
Doing some review, sorry for the delay. I'd like to ask for a high-level description in this MR for how this integration works, with especial focus on how structs are handled (in particular how the JSON <-> struct boundary is handled). |
MOmarMiraj
force-pushed
the
hculea/add-python-support-in-typeshare
branch
from
f4540ab
to
85634d4
Compare
MOmarMiraj
force-pushed
the
hculea/add-python-support-in-typeshare
branch
from
85634d4
to
48a8adb
Compare
amandayu1
force-pushed
the
hculea/add-python-support-in-typeshare
branch
from
fbfde61
to
5c88f19
Compare
amandayu1
force-pushed
the
hculea/add-python-support-in-typeshare
branch
3 times, most recently
from
c901b1b
to
9935aaf
Compare
amandayu1
force-pushed
the
hculea/add-python-support-in-typeshare
branch
from
9935aaf
to
a74e4ce
Compare
fixing optional field set to default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the prior work of @adriangb: #25
This will be picked up in the coming weeks. Would already appreciate a provisional review with high-level feedback on design!