Add support for Kotlin inline value classes #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucretiel
reviewed
Jul 15, 2024
| writeln!(w, "@JvmInline")?; | ||
| writeln!(w, "value class {}{}(", self.prefix, ty.id.renamed)?; | ||
|
|
||
| self.write_element( |
There was a problem hiding this comment.
Is this block equivalent to a similar block in the write_struct code?
|
Wondering if the redacted string code can be deduplicated; otherwise this looks great to me |
Lucretiel
approved these changes
Jul 15, 2024
| @@ -15,7 +15,7 @@ pub struct BestHockeyTeams2 { | |||
| Lies: String, | |||
| } | |||
|
|
|||
| #[typeshare(kotlin = "redacted_to_string")] | |||
| #[typeshare(kotlin = "Redacted")] | |||
There was a problem hiding this comment.
I think the other languages can also have redacted output. It may be better for this to be parsed as #[typeshare(redacted)] allowing each language formatter to choose how the redacted type should be implemented.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances where we are using a type alias in Kotlin when we should be using an inline value class. This pull request adds a Kotlin-specific typeshare decorator for generating these inline value classes. Additionally, updated the
redacted_to_stringdecorator toRedactedso there is a consistent naming convention for the language-specific decorators.