Remove requirement of -go-package from typeshare with go feature #184
+33
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hculea
reviewed
Jul 17, 2024
MOmarMiraj
force-pushed
the
omar/fix-go-package-flag
branch
2 times, most recently
from
7987345
to
e390aea
Compare
seanaye
requested changes
Aug 9, 2024
seanaye
requested changes
Aug 14, 2024
seanaye
approved these changes
Aug 15, 2024
MOmarMiraj
force-pushed
the
omar/fix-go-package-flag
branch
from
1f8c0ae
to
b050dfc
Compare
Add check to see if no package flag is passed or in typeshare.toml Fmt fix clippy fix Cleanup logic and make it cleaner fix logic fix return value cargo clippy fix Cleanup function fix logic of go_package function update logic for error handling fix logic to correctly return package name Capitalize all variant names when configuration specifies so in Go Signed-off-by: Omar Miraj <[email protected]> Add support for Kotlin inline value classes Signed-off-by: Omar Miraj <[email protected]> Introduce redacted typeshare parameter Signed-off-by: Omar Miraj <[email protected]> keep the file output deterministic Signed-off-by: Omar Miraj <[email protected]> Deterministic output I want to use a parallel iterator while walking the input folders however in order to maintain a deterministic output I'll have to keep the crate to parsed data sorted along with the types within each parsed data. Consequently the tests have been updated since they did not have this sorting before. Signed-off-by: Omar Miraj <[email protected]> Add determinism ensurance tests Signed-off-by: Omar Miraj <[email protected]> chore: update changelog and bump version numbers for release v1.10.0-beta.7 Signed-off-by: Omar Miraj <[email protected]> Explicitly format variant types in Go Signed-off-by: Omar Miraj <[email protected]> Remove dead code and switch if else to match Signed-off-by: Omar Miraj <[email protected]> Add check to see if no package flag is passed or in typeshare.toml Fmt fix Signed-off-by: Omar Miraj <[email protected]> Cleanup logic and make it cleaner update logic for error handling fix logic to correctly return package name Capitalize all variant names when configuration specifies so in Go Signed-off-by: Omar Miraj <[email protected]> keep the file output deterministic Deterministic output I want to use a parallel iterator while walking the input folders however in order to maintain a deterministic output I'll have to keep the crate to parsed data sorted along with the types within each parsed data. Consequently the tests have been updated since they did not have this sorting before. Signed-off-by: Omar Miraj <[email protected]> Explicitly format variant types in Go Signed-off-by: Omar Miraj <[email protected]> Remove dead code and switch if else to match Signed-off-by: Omar Miraj <[email protected]>
MOmarMiraj
force-pushed
the
omar/fix-go-package-flag
branch
from
cf96abe
to
75f46b5
Compare
seanaye
requested changes
Aug 26, 2024
seanaye
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the typeshare CLI with go feature enabled, doesn't allow the usage of package in
typeshare.tomlas the CLI requires the --go-package to be there. This MR will tackle that issue by not requiring the --go-package.I also added a check to ensure that the package name is passed as this is a requirement in Golang.
I also added a UT for reading the package name from a
typeshare.toml