Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unions defined with close braces on their own newlines are incorrectly parsed #18

Closed
200sc opened this issue Dec 4, 2021 · 0 comments
Closed

Unions defined with close braces on their own newlines are incorrectly parsed #18

200sc opened this issue Dec 4, 2021 · 0 comments
Assignees
@200sc
Labels
bug Something isn't working

Comments

@200sc
Copy link
Owner

200sc commented Dec 4, 2021

No description provided.

@200sc 200sc added the bug Something isn't working label Dec 4, 2021
@200sc 200sc self-assigned this Dec 4, 2021
200sc added a commit that referenced this issue Dec 4, 2021
@200sc
Fix bug in union and message parsing
d169045 
1. Do not arbitrarily skip tokens after reading a union field, only skip one '}' and optional comments and newlines
2. Enforce that messages do not skip invalid tokens in the middle of their structure

Addresses #18
This was referenced Dec 4, 2021
Merged
Open
@200sc 200sc closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@200sc 200sc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@200sc