Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DigiKey API to v4 #14

Open
1 of 4 tasks
30350n opened this issue Feb 25, 2024 · 3 comments
Open
1 of 4 tasks

Update DigiKey API to v4 #14

30350n opened this issue Feb 25, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@30350n
Copy link
Owner

30350n commented Feb 25, 2024

DigiKey search is somewhat broken right now, the following things need fixing:

  • DigiKey Part Number search doesn't work
  • Parts with multiple packages only return pricing information for one of them

The digikey-api also seems like it's been unmaintained for quite a while now and doesn't support the new Product Information V4 endpoint, which could be helpful here.

  • Find a replacement for / Fork the digikey-api library
  • Update to Product Information V4 API
@30350n 30350n added bug Something isn't working enhancement New feature or request labels Feb 25, 2024
@30350n 30350n added the help wanted Extra attention is needed label Mar 5, 2024
@sle118
Copy link

sle118 commented Mar 7, 2024

Have you had a chance to evaluate the effort? Would you fork the digikey-api altogether, or just implement your own subset of APIs? I might be interested to chip in, although Python isn't my primary language.

@30350n
Copy link
Owner Author

30350n commented Mar 7, 2024

I've started to twiddle around with it a bit, but haven't really gotten anywhere. The perfectionist in me wants to do the whole API generation in a similar way as it's currently done in digikey-api here, but ideally only when building the actual package (so that none of the generated code would actually be part of the git repository).

Things I've learned:

  • swagger-to is poorly implemented and doesn't work with DigiKey swagger files
  • swagger-codegen-cli (this is what digikey-api uses) works, but generates a lot of bloat that has to be sorted through

@30350n 30350n changed the title Fix DigiKey search, Update to API v4 ~Fix DigiKey search,~ Update to API v4 Jun 30, 2024
@30350n 30350n changed the title ~Fix DigiKey search,~ Update to API v4 ~~Fix DigiKey search,~~ Update to API v4 Jun 30, 2024
@30350n 30350n changed the title ~~Fix DigiKey search,~~ Update to API v4 Update DigiKey API to v4 Jun 30, 2024
@30350n
Copy link
Owner Author

30350n commented Jun 30, 2024

Searching for DigiKey part numbers should work again now in 1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants