Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test GitHubAPI w/o OHHTTPStubs #32

Merged
merged 13 commits into from
Apr 12, 2022
Merged

Test GitHubAPI w/o OHHTTPStubs #32

merged 13 commits into from
Apr 12, 2022

Conversation

417-72KI
Copy link
Owner

  • set session in client
  • use session in each functions
  • add stub session
  • deprecate functions using OHHTTPStubs
  • replace tests for GetReleases
  • replace tests for GetRepos
  • add HTTPMethod as enum
  • replace tests for GetUser
  • throw error instead of return response when request is unexpected
  • Revert "throw error instead of return response when request is unexpected"
  • validate request
  • replace tests for Starred
  • remove OHHTTPStubs

@417-72KI 417-72KI merged commit 4bd8336 into main Apr 12, 2022
@417-72KI 417-72KI deleted the test-wo-ohhttpstubs branch April 12, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@417-72KI