Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SSGHCore testable #33

Merged
merged 9 commits into from
Apr 12, 2022
Merged

Make SSGHCore testable #33

merged 9 commits into from
Apr 12, 2022

Conversation

417-72KI
Copy link
Owner

  • extract GitHubClient.Error to top-level
  • create temporary protocol for client
  • rename
  • make GitHubClientImpl as internal
  • extract implementation
  • group
  • remove unused extension
  • remove unused import
  • add test cases for SSGHCore

@417-72KI 417-72KI marked this pull request as ready for review April 12, 2022 09:32
@417-72KI 417-72KI merged commit d22409d into main Apr 12, 2022
@417-72KI 417-72KI deleted the testable-ssghcore branch April 12, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@417-72KI