Adressing module review comment: disclosure + info section on GHEV #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressing review comment: prebid/Prebid.js#11414 (review)
addressing review comment: prebid/Prebid.js#11414 (review)
justadreamer
changed the title
justadreamer
deleted the
feature/51DegreesRtdProvider-disclosure-lengthycomment
branch
justadreamer
pushed a commit
that referenced
this pull request
May 23, 2024
* feat: added exadsadserver.md for PR purposes * fix: after code review * fix: changed main parameters * fix: from code review * fix: clear names * fix: related to markdown lint validation (#3) * EX-21135 - from CR (#5) * fix: related to markdown lint validation * fix: from code review * fix: from code review * EX-21135 - from CR - making URL as relative (#6) * fix: related to markdown lint validation * fix: from code review * fix: from code review * fix: from CR --------- Co-authored-by: Pierre Brouca <[email protected]>
justadreamer
pushed a commit
that referenced
this pull request
May 23, 2024
* feat: added exadsadserver.md for PR purposes * fix: after code review * fix: changed main parameters * fix: from code review * fix: clear names * fix: related to markdown lint validation (#3) * EX-21135 - from CR (#5) * fix: related to markdown lint validation * fix: from code review * fix: from code review * EX-21135 - from CR - making URL as relative (#6) * fix: related to markdown lint validation * fix: from code review * fix: from code review * fix: from CR * fix: changed bidder code --------- Co-authored-by: Pierre Brouca <[email protected]> Co-authored-by: tfoliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing Patrick's review comment
GetHighEntropyValuesvsDelegate-CHinto the description