Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestrator - Single Action NetApps visibility #171

Merged
merged 13 commits into from
Jun 23, 2023

Conversation

Artonus
Copy link
Member

@Artonus Artonus commented Jun 22, 2023

Description

The aim of this feature is to enable communication between multiple NetApps. This scenario makes a few assumptions:

  • The NetApps that can communicate with each other are placed in a single Action during planning
  • All NetApps will know about each other's existence
  • The addresses of the other NetApps are exposed through Environment Variables
  • The environment variable is named exactly as the NetApp it exposes. With exception that instead of -, there are _ and name is uppercase

Fixes: #161

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

What has been changed?

  1. Feature: NetApps within the same action are exposed to each other through environment variables
  2. Doc: documentation of the process

How Has This Been Tested?

  • Unit tests confirming that the environment variables are assigned

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Artonus Artonus added the enhancement New feature or request label Jun 22, 2023
@Artonus Artonus added this to the v0.6 milestone Jun 22, 2023
@Artonus Artonus self-assigned this Jun 22, 2023
@Artonus Artonus linked an issue Jun 22, 2023 that may be closed by this pull request
@Artonus Artonus marked this pull request as ready for review June 23, 2023 09:50
@Artonus Artonus merged commit 73739fc into main Jun 23, 2023
1 check passed
@Artonus Artonus deleted the 161-orchestrator-single-action-netapps-visibility branch June 23, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchestrator - Single Action NetApps visibility
2 participants