Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

134 dynamic gateway reconfiguration #174

Merged
merged 14 commits into from
Jun 30, 2023
Merged

134 dynamic gateway reconfiguration #174

merged 14 commits into from
Jun 30, 2023

Conversation

radu-popescu
Copy link
Contributor

Description

Using the RabbitMQ queueing system, this new feature offers the possibility to automatically reconfigure the gateway to route the traffic to the specific Network Application on demand.

Fixes #134

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

What has been changed?

  1. Feature: Dynamic gateway configuration for WebSockets connection.
  2. Doc: Added Gateway description.

How Has This Been Tested?

  • Test: Application builds and runs normally, the changes have not affected previous functionality.
  • Test: Both Ocelot and YARP are functional.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@radu-popescu radu-popescu added the enhancement New feature or request label Jun 29, 2023
@radu-popescu radu-popescu added this to the v0.6 milestone Jun 29, 2023
@radu-popescu radu-popescu self-assigned this Jun 29, 2023
@radu-popescu radu-popescu linked an issue Jun 29, 2023 that may be closed by this pull request
Dynamic gateway reconfiguration #134
Closed
Artonus
Artonus requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@Artonus Artonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radu-popescu, it looks mostly good to me. I have found a few minor changes to be made and it will be great!

docs/Administrator/Gateway/readme.md Outdated Show resolved Hide resolved
src/OcelotGateway/appsettings.json Outdated Show resolved Hide resolved
src/OcelotGateway/Program.cs Outdated Show resolved Hide resolved
src/OcelotGateway/Services/GatewayConfigurationService.cs Outdated Show resolved Hide resolved
Artonus
Artonus approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Artonus Artonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radu-popescu radu-popescu merged commit ec8d849 into main Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artonus Artonus Artonus approved these changes

Assignees

@radu-popescu radu-popescu

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Dynamic gateway reconfiguration
2 participants
@radu-popescu @Artonus