Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay Network Application integration #176

Merged
merged 20 commits into from
Jul 4, 2023

Conversation

Artonus
Copy link
Member

@Artonus Artonus commented Jun 30, 2023

Description

The PR integrates the ROS-based Network Applications with the WebSocket-based Network Application client. The network applications are exposed internally through the ClusterIP and the traffic is routed through the Gateway.

Fixes #164

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

What has been changed?

  1. Feature: ROS-based network applications are exposed internally through the ClusterIP service
  2. Feature: Orchestrator sends the messages to Gateway to open and close the route to the NetApp
  3. Doc:

How Has This Been Tested?

  • Units tests are passing
  • End-to-end tests to be completed before the integration meeting

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Artonus Artonus linked an issue Jun 30, 2023 that may be closed by this pull request
@Artonus Artonus requested a review from radu-popescu July 3, 2023 13:24
@Artonus Artonus self-assigned this Jul 3, 2023
@Artonus Artonus added the enhancement New feature or request label Jul 3, 2023
@Artonus Artonus added this to the v0.6 milestone Jul 3, 2023
@Artonus Artonus marked this pull request as ready for review July 3, 2023 13:33
@Artonus Artonus merged commit 99c422c into main Jul 4, 2023
1 check passed
@Artonus Artonus deleted the 164-middleware-relay-netapp-configuration branch July 4, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware - Relay NetApp configuration
2 participants