Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support formRequestPath option #31

Merged
merged 2 commits into from
May 19, 2024

Conversation

NaoyaMiyagawa
Copy link
Collaborator

@NaoyaMiyagawa NaoyaMiyagawa commented May 19, 2024

Issues

Changes

This PR enables users to change FormRequest file path from pre-defined default app/Http/Requests to a preferred path with newly added --form-request-path option (default: app/Http/Requests). This option helps projects that follow non-default folder structure such as modular monolith.

Usage:

pnpm laravel-typegen --model-path 'app-modules/auth/src/Models' --output 'app-modules/auth/resources/js/types' --form-request --form-request-path 'app-modules/auth/src/Http/Requests'"

The above is an example command in a project with following folder structure

app/
  - Http/
     - Requests/
app-modules/
  - auth/
    - src/
      - Http/
        - Requests/
    - resources/
      - js/
        - types/
  - ... // other modules
resources/
  - js/
    - types/

Output

Result of debug.sh

(no change)

Sample result of output in modular monolith structure:

Remarks

I wasn't sure which would be better, adding a new option --form-request-path or accepting path value for the existing option --form-request. So far, I followed the way of adding a new option. I feel this is simpler and more consistent with the existing options for users.

@NaoyaMiyagawa
Copy link
Collaborator Author

Hi @7nohe, let me know if there is any concern or further improvements on this :) Thanks!

Copy link
Owner

@7nohe 7nohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@7nohe 7nohe merged commit f0645e5 into 7nohe:main May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support formRequestPath option
2 participants