Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Symfony Insights badge and config #273

Merged
merged 3 commits into from
Oct 20, 2019

Conversation

gregurco
Copy link
Member

@gregurco gregurco commented Oct 10, 2019

Q A
Bug fix no
New feature no
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets -
License MIT

As soon as we don't have Symphony Insights trigger on PR, the badge and config are not actual. Propose to remove them.

@gregurco gregurco added this to the v8 milestone Oct 10, 2019
@gregurco gregurco changed the title Remove Symphony Insights badge Remove Symphony Insights badge and config Oct 11, 2019
@ghost ghost changed the title Remove Symphony Insights badge and config Remove Symfony Insights badge and config Oct 18, 2019
@florianpreusner
Copy link
Member

I readded the project in symfony insights. So it should run now automatically. Unfortunately you can't see any analyzing results anymore. Don't get why open source software has to pay to get some details how to improve the software, especially in the same ecosystem.

So for me it's fine to remove 👍

Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gregurco gregurco merged commit 51a9b7c into 8p:master Oct 20, 2019
@gregurco gregurco deleted the remove-si-badge branch October 20, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants